Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for the Iron180 V2 PCBs #22314

Merged
merged 15 commits into from
Dec 12, 2023
Merged

Adds support for the Iron180 V2 PCBs #22314

merged 15 commits into from
Dec 12, 2023

Conversation

Gondolindrim
Copy link
Contributor

Description

Adds support for the Iron180 V2 PCBs, in two versions: hotswap and solderable. Also moves the V1 PCB files to a v1 folder.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Oct 22, 2023
fauxpark
fauxpark requested changes Oct 22, 2023
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keyboard updates and moves must go through develop.

keyboards/smithrune/iron180/v2s/config.h Outdated Show resolved Hide resolved
keyboards/smithrune/iron180/v2h/halconf.h Outdated Show resolved Hide resolved
@Gondolindrim
Copy link
Contributor Author

Keyboard updates and moves must go through develop.

Changes for the V1 PCB were reverted minus a V1 on info.json. V2 PCBs were added to a dedicated folder.

@Gondolindrim Gondolindrim marked this pull request as ready for review October 22, 2023 01:22
@fauxpark fauxpark changed the base branch from master to develop October 22, 2023 01:49
dunk2k
dunk2k suggested changes Oct 22, 2023
View reviewed changes
keyboards/smithrune/iron180v2/v2h/info.json Outdated Show resolved Hide resolved
keyboards/smithrune/iron180v2/v2h/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/smithrune/iron180v2/v2h/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/smithrune/iron180v2/v2s/info.json Show resolved Hide resolved
keyboards/smithrune/iron180v2/v2s/info.json Outdated Show resolved Hide resolved
keyboards/smithrune/iron180v2/v2h/info.json Outdated Show resolved Hide resolved
zvecr
zvecr requested changes Oct 22, 2023
View reviewed changes
keyboards/smithrune/iron180v2/v2s/rules.mk Outdated Show resolved Hide resolved
keyboards/smithrune/iron180v2/v2s/info.json Outdated Show resolved Hide resolved
keyboards/smithrune/iron180v2/v2h/rules.mk Outdated Show resolved Hide resolved
keyboards/smithrune/iron180v2/v2h/mcuconf.h Outdated Show resolved Hide resolved
keyboards/smithrune/iron180v2/v2h/info.json Outdated Show resolved Hide resolved
keyboards/smithrune/iron180v2/readme.md Outdated Show resolved Hide resolved
keyboards/smithrune/iron180v2/readme.md Show resolved Hide resolved
Gondolindrim and others added 10 commits December 1, 2023 00:19
@Gondolindrim @zvecr
Remove audio feature def from info.json
4e9dd1d 
Co-authored-by: Joel Challis <git@zvecr.com>
@Gondolindrim @zvecr
Remove audio and backlight defs from info.json
46edd22 
Co-authored-by: Joel Challis <git@zvecr.com>
@Gondolindrim @dunk2k
Update defs on info.json
e872940 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@Gondolindrim
Fix README flashing and bootloader instructions
59ccc50
@Gondolindrim @dunk2k
Add community layouts
3a4ba92 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@Gondolindrim @dunk2k
Change keymaps to LAYOUT_all
db68054 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@Gondolindrim @zvecr
Update rules.mk comment
8a351f8 
Co-authored-by: Joel Challis <git@zvecr.com>
@Gondolindrim @zvecr
Update rules.mk comment
ec93d4a 
Co-authored-by: Joel Challis <git@zvecr.com>
@Gondolindrim @dunk2k
Remove split left shift from V2H matrix diagram
bdba3f9 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@Gondolindrim @dunk2k
Remove encoder and rgblight defs, enable LTO
5d6e468 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@fauxpark fauxpark requested a review from a team December 2, 2023 05:20
@drashna drashna merged commit 1f9b653 into qmk:develop Dec 12, 2023
3 checks passed
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
@Gondolindrim @zvecr
@dunk2k @itsjonny96
[Keyboard] Add Iron180 V2 PCB support (qmk#22314)
0791aec 
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
@Gondolindrim @zvecr
@dunk2k @mechlovin
[Keyboard] Add Iron180 V2 PCB support (qmk#22314)
90fb3d4 
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
@Gondolindrim @zvecr
@dunk2k @mechlovin
[Keyboard] Add Iron180 V2 PCB support (qmk#22314)
3f5f4a6 
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@Gondolindrim @zvecr
@dunk2k @nuess0r
[Keyboard] Add Iron180 V2 PCB support (qmk#22314)
dea0b1d 
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k requested changes

@zvecr zvecr zvecr requested changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gondolindrim @drashna @fauxpark @zvecr @dunk2k